Missing filter condition in linkit.ckeditor5.yml

Submitted the MR, attaching a patch for composer.

Awesome. This makes a lot of sense. I was unaware of the `filter` attribute for CKEditor configuration.

However, this change appears to cause tests to fail, where they are not on 7.x (see https://git.drupalcode.org/project/linkit/-/pipelines/517840). Therefore, I'm setting this to "Needs work" to identify whether this filter is in fact interfering with the necessary elements that are allowed on the CKEditor-enabled text format, as indicated by the test output:

The current CKEditor 5 build requires the following elements and attributes: <br><code>&lt;br&gt; &lt;p&gt; &lt;* dir=&quot;ltr rtl&quot; lang&gt; &lt;a href&gt;The following elements are not supported: &lt;a data-entity-type data-entity-uuid data-entity-substitution&gt;',

Okay, the issue with the tests in fact demonstrates the scope change introduced by adding filter! In other words, without explicitly enabling the Linkit text format filter, it is NOT loading the JS, which is what this change is designed to accomplish. I updated the tests.

tested on D10.5
with the patch applied - if Linkit filter is not applied to editor, linkit.js is not loaded - as per fix.

Note: D11.2 wouldn't load linkit.js even without the patch.

Sorry to bump a closed issue, but I think a new issue might be overkill. I just spent some time debugging why Linkit was no longer working on my site. Turns out, this issue is "to blame", because my input formats did not have the filter enabled; we were in fact relying on the filter being optional. Might it be an idea to add a snippet to the releases notes for 7.0.7 → stating as much? E.g. "Note: Any input filter where Linkit should work now must have the Linkit input filter enabled."

Thanks for the suggestion, and sorry about the headache. Callout added to https://www.drupal.org/project/linkit/releases/7.0.7 →

🙏

Automatically closed - issue fixed for 2 weeks with no activity.