Contrib.social

Merge fullcalendar_legend into primary module

Open on Drupal.org →
Created on 6 June 2025, 18 days ago

Problem/Motivation

While I was working on 🐛 Missing Schema Error for Active I had the thought that there's no real reason for the fullcalendar_legend module to exist now that the legend is a Views area plugin. I sort of get why it was a separate module previously. The legend was a block and some people think they have way too many blocks clogging up the admin lists. So they want the ability to reduce those numbers by uninstalling modules. But how many of us have that problem when selecting a Views area plugin? I'd wager not many. Instead it seems like an unnecessary impediment to adding the legend functionality.

Proposed resolution

Move everything from the fullcalendar_legend module into the primary fullcalendar module. Deprecate fullcalendar_legend.

Remaining tasks

  • Evaluate the idea. Close the issue if it's undesirable.
  • Do the work.

User interface changes

API changes

Data model changes

📌 Task
Status

Active

Version

3.0

Component

FullCalendar Legend

Created by

🇺🇸United States dcam

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dcam
  • Comment 18 days ago →
    🇺🇸United States dcam

    I'm willing to do the work if it's decided that the issue should move forward.

  • Merge request !68Merged fullcalendar_legend into the primary module → (Open) created by dcam
  • Pipeline finished with Success
    18 days ago
    Total: 177s
    #516671
  • Comment 18 days ago →
    🇺🇸United States dcam

    Since the schema issue was merged I decided to make an MR. It only took a few minutes of work.

    If it's decided to move this forward then I'll make a change record. And the lifecycle_link in the info file will have to be updated. Just set the issue back to NW with a note.

    I wasn't certain if it's better to make an update function to uninstall fullcalendar_legend or let site builders do it themselves. I decided to err on the side of not uninstalling something that custom projects might depend on. What are your thoughts?

    I left the issue version as 3.0.x to get the latest code changes, but per the semver rules this will force the release of 3.1.0.

  • Comment 15 days ago →
    🇩🇪Germany jurgenhaas Gottmadingen

    I think it makes sense to bring the legends into the main module. What we could still do is to provide a views setting whether the extra plugin should be enabled or not. But even if it is always enabled, a block should only be provided when a view with a legend exists, doesn't it?

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024