- Issue created by @steven jones
- Merge request !2Issue #3528826: Provide less scary paragraphs table widgets → (Merged) created by steven jones
- 🇬🇧United Kingdom rossb89 Bristol
I've taken a look at the merge request and the code looks like a great simplification of the original
paragraphs_table
retaining the ability to view the table whilst removing all of the other bits of more complex functionality.One issue i've found though: in
ParagraphsTableWidget.php::164
, there is still a logic block referencing settings that used to be present indefaultSettings()
in this class, but are no longer present.Could you please remove the unnecessary logic block that is still referencing those bits. In fact, looks like without that logic block, all that's left is the method going to call the parent
::addMoreSubmit()
method anyway I think? - 🇬🇧United Kingdom steven jones
@rossb89 thanks very much. I've removed that entire method because yeah, it wasn't needed.
-
steven jones →
committed 243643d5 on 8.x-2.x
Issue #3528826 by steven jones, rossb89: Provide less scary paragraphs...
-
steven jones →
committed 243643d5 on 8.x-2.x
Automatically closed - issue fixed for 2 weeks with no activity.