- Issue created by @rupertj
- Merge request !7Filter out unchecked checkbox entries and return if there aren't any. → (Open) created by rupertj
- 🇬🇧United Kingdom joachim
Why do we need to array_filter(array_intersect())?
I thought I had test coverage for this one :(
- 🇬🇧United Kingdom rupertj Bristol, UK
The array_filter takes out all the checkbox values that didn't get chosen. Without that, they're still there and show up as clashing bundles. (See the screenshots I just added.)
- 🇬🇧United Kingdom joachim
Ahhhh checkboxes. ARGH. Maybe I tested on a form without unselected things!
In that case, the filtering should be happening much earlier -- on the two parameters to the intersect for one thing, but probably even in the form, as the method you're changing is supposed to be working with config (where AFAICT there won't be stupid empty values), and is only being called from the form as a hack.
- 🇬🇧United Kingdom rupertj Bristol, UK
I had the same reaction to checkboxes when I found the flaw!
Filtering those values out in the form makes a lot of sense. I'll move it there.