Boolean facet does not show the "FALSE" value

Patch to solve issue above using method 1

@marckwee, thank you for the contribution!

I committed your code to a merge request to make it easier for me to review.

I took a very quick look at your patch: the changes seem clear to me, but I haven't yet had a chance to run the changed code... I may have more feedback when I do.

I didn't see any automated tests in your patch... the Elasticsearch Connector module maintainers prefer to accept merge requests that have passing automated tests. Automated tests ultimately benefit you, because they ensure that future changes to this module (i.e.: by other people) will not break the functionality that your site depends on!

I don't think that we have any automated tests for Facets yet ( I wrote a manual test → but haven't had the time to turn it into code yet).

Are you interested in learning how to write an automated test?

If you describe how to run a test manually, then I may be able to suggest how to automate it (i.e.: if you're interested in learning to write a test), or write a test myself (if you aren't interested in learning to write a test).

Hi MR Parker,

I wouldn't mind to write tests for the issues. However I am a bit lost with using MR/PR with Drupal instead of patches + what kind of tests to write. Can you give me some pointers.=)

@marckwee, apologies for the delay in getting back to you! I'm happy to help how I can!

I can't see any metadata in your patch file to indicate how you created it, but I found that the merge-request workflow was pretty similar to how I was generating patches before, and it was also pretty similar to how my teams were working on client sites, so it was an easy transition for me. (hopefully those anecdotes are encouraging?)

At a high level, in the MR-based workflow, you:

1. Use the Create issue fork button (or Create new branch link) in the d.o issue (below the Issue Summary, just above the Comments h2) to create an Issue Fork and Branch for your changes (but note that I've already done this for you for this issue!)
2. Clone the module to your local machine (using the Version control tab on the project page → )
   • Note it will work if you clone the module into your existing site, but I prefer to work on modules in an isolated sandbox, because I've run into many instances where my client's site's configuration is contributes to the problem(s) I've been trying to fix and/or affects my patch in a way that works for my client's site but not the rest of the Drupal community.
   • I've documented how I set up an isolated sandbox test environment for Elasticsearch Connector: here are my instructions for setting up a local environment → — hopefully this is helpful
3. Use the Show commands link beside the name of the Issue Fork in the d.o issue (below the Issue Summary, above the Create new branch link) to add the Issue Fork as a git remote, then switch to the branch
4. Make your changes in the branch and commit
5. Push your commits to the Issue fork
   • Under a patch-based workflow, at this point, I would have instead run git diff against the main branch to generate the patch file
6. Make a merge request → (but note that I've already done this for you for this issue!)
7. Look for feedback from testbot

For more-detailed documentation, see the guide on Using GitLab to contribute to Drupal → . The part of the guide about Creating issue forks → explains the d.o issue UI, with screenshots (which I found helpful!)

Please let me know if you have any questions! (I'll try to reply to you more-quickly in the future!)

(updated the status (Active -> Needs work), and updated the version to 8.0.x as this issue applies to the dev branch as well)