- Issue created by @MarcKwee
- First commit to issue fork.
- Merge request !94Issue #3526730: Boolean facet does not show the "FALSE" value → (Open) created by mparker17
- 🇨🇦Canada mparker17 UTC-4
@marckwee, thank you for the contribution!
I committed your code to a merge request to make it easier for me to review.
I took a very quick look at your patch: the changes seem clear to me, but I haven't yet had a chance to run the changed code... I may have more feedback when I do.
I didn't see any automated tests in your patch... the Elasticsearch Connector module maintainers prefer to accept merge requests that have passing automated tests. Automated tests ultimately benefit you, because they ensure that future changes to this module (i.e.: by other people) will not break the functionality that your site depends on!
I don't think that we have any automated tests for Facets yet ( I wrote a manual test → but haven't had the time to turn it into code yet).
Are you interested in learning how to write an automated test?
If you describe how to run a test manually, then I may be able to suggest how to automate it (i.e.: if you're interested in learning to write a test), or write a test myself (if you aren't interested in learning to write a test).