Consider allowing first stage tests to fail when an MR is in draft.

Created on 26 May 2025, 6 days ago

Problem/Motivation

While we want the first stage of tests to help keep core consistent and catch issues with phpstan. There are situations such as architectural issues you would want full tests to run even if phpcs is failing for example.

I would like to suggest that if an MR is in draft then the first stage of tests get a new rule that allows failure.
We would need to ensure that code is not committed from a draft MR as well.

Steps to reproduce

See:
https://www.drupal.org/project/drupal/issues/3525331 📌 Slowly, very slowly start OOPifying the render system Needs review
https://www.drupal.org/project/drupal/issues/3526388 📌 [pp-1] Deprecate drupal_verify_install_file Active

Neither of those are really in a position to be even in needs review, but it would be valuable to see a full test run even if there is a spelling mistake. This would have the potential to increase resources used by the DA, but we could be cognizant of when an issue uses Draft MRs

Proposed resolution

Rule to allow failure for most jobs in the first column when the MR is in Draft

Remaining tasks

Determine if there is a better way to do this.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

📌 Task

Status

Active

Version

11.0 🔥

Component

base system

Created by

🇺🇸United States nicxvan

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @nicxvan
Comment 5 days ago →
🇦🇺Australia mstrelan
Could possibly make use of labels on the MR as well
Comment 5 days ago →
🇺🇸United States nicxvan
I was concerned about how visible those would be for core committers / reviewers, but that might be a viable way too.
Comment 5 days ago →
🇺🇸United States nicxvan
https://www.drupal.org/project/drupal/issues/3515704 📌 Move unit tests to a 'unit tests' stage Active may have some examples to pull from.
Comment 5 days ago →
🇺🇸United States nicxvan
Changes from gitlab ci here: https://git.drupalcode.org/project/drupal/-/merge_requests/11841/diffs

More notes from @mstrelan:
https://forum.gitlab.com/t/how-to-share-artifacts-even-on-job-failure/69393
https://docs.gitlab.com/ci/yaml/#artifactswhen

So we might add this:
allow_failure: true
artifacts when:always

When a certain label is applied or it's a draft.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024