compatibility with linkit entity title default

Open on Drupal.org →

Created on 23 May 2025, 3 months ago

Problem/Motivation

There is some work here ( https://www.drupal.org/project/linkit/issues/3388565 ✨ Display node title (a text) in by default when creating link in ckeditor5 Closed: duplicate ) towards allowing the linkit module to default link text to entity titles instead of entity paths.

As outlined in this comment ( https://www.drupal.org/project/linkit/issues/3388565#comment-15609354 ✨ Display node title (a text) in by default when creating link in ckeditor5 Closed: duplicate ), it isn't compatible with editor_advanced_link.

Steps to reproduce

Using the linkit patch from #3388565 while also having editor_advanced_link enabled, the inserted link does not default to the entity title as desired.

Proposed resolution

The ckeditor plugins in linkit and editor_advanced_link have some duplicate code. See function _addExtraAttributeOnLinkCommandExecute, which is based on linkit's function _addExtraAttributesOnLinkCommandExecute.

Bring the editor_advanced_link ckeditor plugin in-line reflect the changes made to the above linkit function changes from #3388565

✨ Feature request

Status

Active

Version

2.2

Component

Code

Created by

🇦🇺Australia drasgardian

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!33compatibility with linkit entity title default
Closed
Unnamed author
updated 3 months ago
!34compatibility with linkit entity title default
Open
Unnamed author
updated 3 months ago

Comments & Activities

Issue created by @drasgardian
Merge request !33Draft: Resolve #3526372 "Compatibility with linkit" → (Closed) created by Unnamed author
Comment 3 months ago →
System Message
drasgardian → closed merge request !33
Merge request !34project/editor_advanced_link\!33 allow editor_advanced_link ckeditor plugin to... → (Open) created by Unnamed author
Pipeline finished with Failed
3 months ago
Total: 395s
#505191
Comment 3 months ago →
🇦🇺Australia drasgardian
Comment 4 days ago →
🇬🇧United Kingdom robcarr Perthshire, Scotland
I'm not quite sure what the issue is... I've noticed that if the CKE text format has both Linkit and the Editor Advanced Link filters enabled, when adding a link, the title attribute is not populated in the CKE/Linkit form, but is actually rendered in HTML (if Automatically set the title attribute to that of the (translated) referenced content is set in Text Format > Linkit URL converter). Is this the problem you're addressing here?

I cannot apply the MR as a patch file, and looks like the MR has failed

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024