- Issue created by @SirClickALot
- π©πͺGermany filburt
Hi,
you could try the following - worked for me:
function custom_h5p_overrides_h5p_styles_alter(array &$styles, array $libraries, string $mode): void {
...
} Have the same issue in both 2.0.0-alpha5 and 2.0.0-alpha6. #2 did not work for me.
Debugging shows that the hook is not being called. Worked in D10 alpha4.- π¬π§United Kingdom SirClickALot Somerset
@anzi31, Agreed, the hook is simply not being called and #2 could not really make any difference.
We do love H5P for educational project but forward-compatibility of this module just does not seem to me to be going to happen so we are finding ourselves look around for other alternatives.
Looks like \Drupal::moduleHandler()->alter() was removed from H5PDefaultFormatter.php.
If you embed a quiz, it works, but if it is an iframe, it does not.- πΊπΈUnited States illeace
What I found using Drupal 11 and 2.0.0-alpha6 is that my H5P CSS customizations worked when viewing the H5P embed link, and also were visible when editing the H5P, but not when viewing the node directly. After applying this patch, I also see those CSS customizations when viewing the node. I'm marking this RTBC.
- Merge request !35HFP-2184 Added missing metadata to content upgrade process β (Merged) created by sim_1
- πΊπΈUnited States sim_1
Merged and marking as fixed. Thanks everyone for working on this and testing!
Automatically closed - issue fixed for 2 weeks with no activity.
- πͺπͺEstonia pjotr.savitski
I could be wrong as I haven't tried using the code yet, but it somehow seems that only the first script and style would be added by the
$jsFilePaths[] = $aggregatedJS['scripts'][0][0];
and
$cssFilePaths[] = $aggregatedCSS['styles'][0][0];
Alter hooks could potentially add multiple scripts/styles and the solution should probably use array merge to add all the scripts/styles to existing ones.