- Issue created by @mxh
- Merge request !511Issue #3526077 by mxh: Add option to disable ECA programmatically → (Closed) created by mxh
- 🇩🇪Germany jurgenhaas Gottmadingen
We already have a kill switch for ECA, which is implemented in
\Drupal\eca\EventSubscriber\DynamicSubscriber::onEvent
. Would it be possible to move the suggested kill-switch from this MR into that context as well? That way, we have the same purpose combined in the same location, certainly better for long term maintainability. - 🇩🇪Germany mxh Offenburg
Yeah, this might work too. Or move the logic from the event into the Processor. DynamicSubscriber should be as "dump" as possible and only serve one purpose. Feels a bit odd to disable the processor there.
- 🇩🇪Germany jurgenhaas Gottmadingen
The intention back then has been to provide a kill switch that disables all of ECA as early as possible. And that's in the subscriber, where it comes with no overhead except for that 1 line to check if the switch is set or not.
-
jurgenhaas →
committed 991c5dc4 on 3.0.x
Issue #3526077 by mxh, jurgenhaas: Add option to disable ECA...
-
jurgenhaas →
committed 991c5dc4 on 3.0.x
-
jurgenhaas →
committed b927f634 on 2.1.x
Issue #3526077 by mxh, jurgenhaas: Add option to disable ECA...
-
jurgenhaas →
committed b927f634 on 2.1.x
- 🇩🇪Germany jurgenhaas Gottmadingen
I've added this to the
DynamicSubscriber
now so that it's together with the other tool that allows to turn off ECA. Also back ported to 2.1.x - Issue was unassigned.
- Status changed to Fixed
3 days ago 3:09pm 30 July 2025 Automatically closed - issue fixed for 2 weeks with no activity.