Suspected fix for test flake

Created on 22 May 2025, 21 days ago

Overview

I think I have figured out a reason the tests can be flakey - specifically around operations that involve the right-click context menu.

Proposed resolution

In ComponentContextMenu.tsx we have a useEffect that if the canvasViewPort is updated (x, y and scale) then the context menu should close. This is done to prevent the menu becoming mis-aligned with the location the user right clicked to initially open it.

However, cypress automatically scrolls the page often when selecting/checking elements. Even just cy.get() will scroll the target element into view if required.

When scrolling occurs, the update for the x/y position of the canvas is updated after a 250ms debounce which I think explains why the issue is flakey! In some case the test is running fast enough that it can open the menu and click the item before the scroll position updates and closes the menu.

User interface changes

🐛 Bug report

Status

Active

Version

0.0

Component

Page builder

Created by

🇬🇧United Kingdom jessebaker

Live updates comments and jobs are added and updated live.

Merge Requests

!1060Suspected fix for test flake
Merged
🇬🇧United Kingdom jessebaker
updated 21 days ago

Comments & Activities

Issue created by @jessebaker
Merge request !1060Attempted fix for flakey CY tests → (Merged) created by jessebaker
Comment 21 days ago →
🇬🇧United Kingdom jessebaker
First commit to issue fork.
Comment 21 days ago →
System Message

bnjmnm → committed 9a514437 on 0.x authored by jessebaker →
Issue #3526034: Suspected fix for test flake
Comment 21 days ago →
🇺🇸United States bnjmnm Ann Arbor, MI
Yep the moving / scrolling seems to be one of the more common intermittent issues here. good find.
Comment 7 days ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024