Invalidate cached responses when new redirects are added

Implementing the quick - but less efficient - solution for now.

Interesting bug and yeah clearing all redirects out of the cache when generating or deleting redirects does feel sub-optimal. I feel that to fix this bug properly we should be adding test coverage to ensure we've got the bug and any edge cases we can imagine covered. Also adding test coverage will make it easier to move to a better solution.

Going to see if I can write a failing test.

I've found the bug here. It's because we're not adding all the redirects involved when processing a redirect chain - we're only adding the last one. Therefore when we update another redirect in the chain the cache is not correctly invalidated. Adding all the redirects in makes the system work as expected.

Added a comment on the phpstan thing we discussed.

Thanks @berdir

actually fails on cspell now.

@berdir yay! No regressions :)

Yes, point for you in that argument I guess ;)

Automatically closed - issue fixed for 2 weeks with no activity.