ApplyCoupon is broken

milanbombschliip → closed merge request !14

Phpunit schema extension tests are failing. But they are also failing on 2.0.x if you only upgrade to PHP 8.3 https://git.drupalcode.org/issue/graphql_commerce-3525869/-/pipelines/50.... PHP 8.2 is not available in the Drupal pipeline anymore. All module functions (including the GetCart Graphql endpoint) are working if I include my code into my project.

Tests are fixed now. Needed to enable the 'default' bundles in the tests and change the addToCart endpoint to resolve the order inside the resolve() function to better handle nullable input.

milanbombschliip → closed merge request !15

Finally hopefully I have some time to review this properly.

On the one hand https://github.com/ddev/ddev-drupal-contrib/blob/main/README.md says

Commit the changes in the .ddev folder after this plugin installs. This saves other users from having to install this integration.

However, https://www.drupal.org/project/search_api/issues/3520659#comment-16149749 ✨ Enabled local development env with DDEV Active says

Hi, DDEV maintainer here. I don't usually encourage committing .ddev in contexts like this.

I also feel bad about committing it, so let's remove all ide and ddev related additions from the MR.

@czigor Agree. Should I do it or will you? Sorry for not making different issues for each of the improvements in this MR.

@milanbombschliip I've already started, thanks. And now the actual review part.

Added some CS and test fixes as well.

Automatically closed - issue fixed for 2 weeks with no activity.