- Issue created by @anup.singh
- Merge request !68Rewrite the Condition plugin and handle wildcard and disabled state for Context all. → (Open) created by anup.singh
- 🇮🇳India anup.singh
anup.singh → changed the visibility of the branch 3525469-reuse-code to hidden.
- 🇮🇳India anup.singh
anup.singh → changed the visibility of the branch 3525469-reuse-code to active.
- Merge request !69Rewrite the Condition plugin an dhandle fail scenarios. → (Open) created by anup.singh
- 🇮🇳India anup.singh
Created a new MR to cover following scenarios
- Remove duplicate code by extending the class and it's functions.
- Log a warning message if entered string has no valid context.
- Status changed to Needs review
15 days ago 10:48am 18 August 2025 - 🇸🇮Slovenia deaom
I couldn't make the page break when using the *, a more specific steps to reproduce the mentioned issues are needed.
The MR69 has a typo with the new logger message, line 167 in the ContextAll:
$this->logger->warning('String "%text" used has no a valid context.', ['%text' => $key]);
should probably be without the a before valid:
$this->logger->warning('String "%text" used has no valid context.', ['%text' => $key]);There are also small code changes than can be applied, like substr replaced with str_starts_with etc. Leaving the status to needs review, as I would really like to have exact steps to reproduce the mentioned issues. The code overall looks good.