getProcessedEntity() and the call to it should document that it saves the entity if it's new

Created on 19 May 2025, 3 days ago

Problem/Motivation

In ImportService, we have:

      $processed_entity = $this->getProcessedEntity($entity_data);
SNIP
      $processed_entity->save();

which makes you think that the single save line is the first time the entity is saved.

But getProcessedEntity() actually saves the entity if it's new to the client.

This needs documentation.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

4.0

Component

Documentation

Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024