- Issue created by @mkalkbrenner
- π©πͺGermany mkalkbrenner π©πͺ
mkalkbrenner β changed the visibility of the branch 1.0.x to hidden.
- Merge request !3Issue #3525221 by mkalkbrenner: Allow to delete revisions of any revisionable enitity type at once β (Merged) created by mkalkbrenner
- π©πͺGermany mkalkbrenner π©πͺ
I get an error during queue:run. I'll check that ...
- π©πͺGermany mkalkbrenner π©πͺ
The issue was with profile entities. That had to be handled in β¨ Support all entity types Active .
So I decided to combine both merge requests here. - π©πͺGermany mkalkbrenner π©πͺ
I noticed two critical issues during testing:
- The keep parameter had no effect.
- The performance is really bad on big databases.
The first one is a bug introduced in the dev branch.
The second is caused by the fact that all entities of a requested type or bundle are queued regardless how many revisions exist in database. In case of one million nodes, that takes a significant amount of time, CPU and memory to load all of them to count the number of revisions.
It is way better to only put those into the queue that have more revisions than to keep.I fixed both issues within the MR instead of opening new ones because the code changed too much.
BTW, I implemented getting the entity IDs as SQL. Loading entities would quickly run out of memory.
- πΊπΈUnited States j-barnes
Thanks for the work on this, this is looking great. Going to do some testing on it and we will get it in.
- π©πͺGermany mkalkbrenner π©πͺ
I did some more tests and found a minor issue that counting revisions per language needs to be done on the data table.
- πΊπΈUnited States j-barnes
@mkalkbrenner - this is working much better now! Do you think it's worth adding some extra logic in the
getRevisionableEntityTypes()
to filter out some of the entity types that might not be applicable like paragraphs or unique ones like menu_link_content where the entity_type_id might differ? - π©πͺGermany mkalkbrenner π©πͺ
I already thought about exclude lists.
But I suggest to commit this one first as it contains bug fixes and performance improvements without breaking any existing functinality. And maybe another beta release.
Then we could think about the next steps. -
j-barnes β
committed dab155c8 on 1.0.x authored by
mkalkbrenner β
Issue #3525221 by mkalkbrenner: Allow to delete revisions of any...
-
j-barnes β
committed dab155c8 on 1.0.x authored by
mkalkbrenner β
Automatically closed - issue fixed for 2 weeks with no activity.