NodeRevisionsAllTest::testRevisions() fails in 11.1.x

Created on 17 May 2025, 6 days ago

Problem/Motivation

The test NodeRevisionsAllTest::testRevisions() fails in 11.1.x.
It is failing in 11.1.7, but passes in 11.1.6.

git bisect reveals this culprit: 🐛 NodeController::revisionOverview is uncacheable Needs review
Interestingly, 11.x also contains this commit, but here we don't get the failure.

Steps to reproduce

Proposed resolution

Investigate further:
- Is the revision list cached at all in 11.x?
- What would be required cache tags for a revision list? Can this even be cached ever?

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Active

Version

11.1 🔥

Component

node system

Created by

🇩🇪Germany donquixote

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @donquixote
  • 🇩🇪Germany donquixote

    The MR works for me in local.

    However, I am a bit puzzled by this:

    • In 11.x I don't see node being added as cacheable dependency, and yet no fail.
      Maybe this is not cached at all in 11.x?
    • On the other hand, I don't know if the node or entity itself is even sufficient cache tags for a revision list.
      If you change (or delete) a revision that does not change the current/published revision, does this even invalidate cache tags for the entity/node?
  • Pipeline finished with Failed
    6 days ago
    Total: 2141s
    #499910
  • Pipeline finished with Failed
    6 days ago
    #499915
  • 🇦🇺Australia acbramley

    I think we can close this one now that the original is reverted and test both branches over there?

  • 🇩🇪Germany donquixote

    Ok for me.
    In the original issue we need to determine if a revision list should be cacheable at all, with which cache tags, and then add more tests.

Production build 0.71.5 2024