- Issue created by @scott_euser
- 🇬🇧United Kingdom scott_euser
- Shortest I could come up with for a title that explains to the user what the purpose is.
- Updated the empty option to match that (+ use typical drupal core any/all labelling of `- label -`
Thanks!
- 🇬🇧United Kingdom scott_euser
I think you're either manually redoing the work in the merge request or maybe not seeing the merge requests at all? Just to help you find your way around, adding screenshots of what I see from other issues (and other projects where I am maintainer). You may also find it easier to get support in Drupal Slack https://www.drupal.org/community/contributor-guide/reference-information... → - you can also find me there with handle scott_euser
So Merge Requests are the Gitlab equivalent to Pull Requests and drupal.org issue queue has an intergration with Gitlab. So they get added to the top of the issue:
- You can click from there to review
- You can also expand that area to fetch & checkout the fork when you want to do any manual checks
- You can click 'Get push access' to get yourself access to the fork if you want to make changes to someone else's contribution
- You can add comments or code change suggestions via Gitlab's merge request UI
Then inside the merge request you can click merge:
Or you can also merge via the issue itself:
Both of these result in the commit message appearing in the issue.
You still have to however manually credit the contributors via the issue (just above the save button).
More details here in the guide: https://www.drupal.org/docs/develop/git/git-for-drupal-project-maintainers →
Hope this is helpful! Feel free to reach out in drupal slack :)
- 🇬🇧United Kingdom scott_euser
Ah and by the way its not necessary to tag and release after every merge. Most maintainers will group a number of changes together and tag and release all at once. On bigger projects (so maybe not here) maintainers will often leave things merge on the dev release for a few weeks to give a chance for the community to flag any regressions before an official release is made.
- 🇬🇧United Kingdom dahousecat
Thanks Scott, that is super helpful.
I just merged my first MR on drupal.org and credited you.
Automatically closed - issue fixed for 2 weeks with no activity.