There are a few places in this module where \Drupal:: calls are used in classes. Best practice is to use dependency injection instead.
References:
This is a follow-up to
📌
Fix PHPStan errors
Active
, which added a phpstan-baseline.neon file to document and ignore these errors and allow PHPStan tests to pass.
Remove the phpstan-baseline.neon file from the root directory of the codebase and run PHPStan. Observe the following errors:
------ ------------------------------------------------------------------------------
Line web/modules/jsonapi_schema/src/Normalizer/DataDefinitionNormalizer.php
------ ------------------------------------------------------------------------------
91 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------
------ -------------------------------------------------------------------------------------
Line web/modules/jsonapi_schema/src/Normalizer/RelationshipFieldDefinitionNormalizer.php
------ -------------------------------------------------------------------------------------
104 \Drupal calls should be avoided in classes, use dependency injection instead
------ -------------------------------------------------------------------------------------
We should use dependency injection instead of \Drupal calls.
However, doing so would mean changing the __construct() arguments for our DataDefinitionNormalizer class, which all of our normalizer classes extend from, and which may be extended by contrib/custom normalizers downstream. As such, this should be considered a breaking change, and should not be done until we are ready to take a major version release, in line with semantic versioning.
Here is the parent issue for version 2.0: 🌱 [Meta, Plan] Version 2.0 Active .
phpstan-baseline.neon and replaces \Drupal calls with dependency injection.\Drupal calls are introduced after
📌
Fix PHPStan errors
Active
is merged.2.x branch.None.
This will change the __construct() parameters of the JSON:API Schema normalizer classes. Downstream classes in contrib or custom modules may need to update their code accordingly, if they are overriding the __construct() method themselves.
None.
Active
1.0
Code
Opened a merge request, and tests all passed.
Marking this as "postponed" on 🌱 [Meta, Plan] Version 2.0 Active .