Contrib.social

InvalidArgumentException: The user-entered string must begin with a '/', '?', or '#'.

Open on Drupal.org →
Created on 15 May 2025, 24 days ago

Problem/Motivation

When working with Drupal 10.4, I noticed the following error:

InvalidArgumentException: The user-entered string 'https://test.ddev.site/en/admin/content' must begin with a '/', '?', or '#'. in Drupal\Core\Url::fromUserInput() (line 216 of core/lib/Drupal/Core/Url.php).
Drupal\type_tray\Controller\TypeTrayController->addPage(Object) (Line: 23)
Drupal\gin_type_tray\Controller\GinTypeTrayController->addPage(Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)

Steps to reproduce

Spool up a site in DDEV using Drupal's WxT Profile, once its running, visit the Add Content and try to add a Basic Page.

Proposed resolution

Looking at the offending code I found this:

          // @codingStandardsIgnoreLine
          $all_nodes_label = $this->t($settings['existing_nodes_link_text']);

          // Remove scripts/style from the label.
          $all_nodes_label = Xss::filterAdmin($all_nodes_label);

          $admin_content_url = Url::fromRoute('system.admin_content')->toString();
          $all_nodes_url = Url::fromUserInput($admin_content_url, ['query' => ['type' => $type->id()]]);
          $build['#items'][$category][$type->id()]['#nodes_by_type_link'] = Link::fromTextAndUrl($all_nodes_label, $all_nodes_url);

There are a few things I believe to be causing the problem here:

  1. The Class Url and its method fromUserInput is expecting a path and not a fully qualified domain name. Hence the error.
  2. The $all_nodes_label can have HTML in it which leads to html converted characters.

I propose the following patch to resolve some of these issues and better contextualize the mechanism:

          $admin_content_url = Url::fromRoute('system.admin_content', ['type' => $type->id()]);
          $build['#items'][$category][$type->id()]['#nodes_by_type_link'] = [
            '#type' => 'link',
            '#title' => [
              '#markup' => $all_nodes_label,
            ],
            '#url' => $admin_content_url,
            '#options' => ['html' => TRUE],
          ];

Here we pass the type for the admin_content_url straight into the fromRoute method, alleviating the need to use a second method and we build the item as a link markup passing the option "html" as true. This allows the link to render the HTML in the label and improving the extensibility of the code.

🐛 Bug report
Status

Active

Version

1.3

Component

Code

Created by

🇨🇦Canada wilco

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @wilco
  • Comment 24 days ago →
    🇨🇦Canada wilco

    The following ticket relates to this: https://www.drupal.org/project/type_tray/issues/3244710 📌 Do not hard code /admin/content Fixed

  • Comment 20 days ago →
    🇺🇸United States dave reid Nebraska USA

    dave reid → made their first commit to this issue’s fork.

  • Merge request !31Fix generating links by node type → (Merged) created by dave reid
  • Pipeline finished with Canceled
    20 days ago
    Total: 842s
    #501097
  • Pipeline finished with Success
    20 days ago
    Total: 160s
    #501105
  • Comment 20 days ago →
    🇺🇸United States dave reid Nebraska USA

    I can't reproduce the issue with the exception with a plain install of D11 and the Type Tray module, but I thought we could simplify the code by just calling Link::createFromRoute() once instead of generating URLs and Links three times and passing them within each other. I also found an issue with the <em> tags being escaped, so I moved the Xss::filterAdmin() to before calling t(), which resolves the issue.

  • Comment 20 days ago →
    🇺🇸United States dave reid Nebraska USA

    @wilco I also attempted a fresh install of the current https://github.com/drupalwxt/wxt-project using DDEV and this module along with gin_type_tray. I can only reproduce the escaped HTML issue and not the fatal error you have reported here. Could you help test the changes in the MR to see if those resolve the issue for you? I believe that they would.

  • Comment 20 days ago →
    🇪🇸Spain marcoscano Barcelona, Spain

    I have spent some time looking into this today, and I too, am unable to reproduce it.
    @wilco please update testing instructions on a fresh install if you can, or test if the MR provided solves the issue for your particular case.
    Also, thanks @dave reid for helping out! 👍

  • Pipeline finished with Skipped
    17 days ago
    #504543
  • Comment 17 days ago →
    System Message
  • Comment 17 days ago →
    🇪🇸Spain marcoscano Barcelona, Spain

    Let's go with the identified fix for now, please open a new one with steps to reproduce if there is something else to be fixed here.
    Thanks all!

  • Comment 3 days ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024