- Issue created by @in0ni
- πΊπΈUnited States dcam
No roadblocks really. I just don't keep up to date on new releases of the JS. Or ever think about it. Do you have any indication if your bug fix will be accepted soon? I can hold off adding a new version until it's ready.
- πΊπΈUnited States dcam
Part of the problem is that the repo owner makes new tags, but not new releases. You can't subscribe to new tags as far as I can see.
- πΊπΈUnited States in0ni
Ok, I guess there is also concern due to the "(not recommended)" message, which indicates perhaps not properly working.
I have yet to create a patch for the bug, just found it yesterday once the ticket is created I can share for reference. When I first tried this module, which we had requirements to implement, I remember the latest version not working properly -- so we kept it at the recommended version.
I would say if support for latest version is possible rather easily, go ahead no need to wait for the fix. As it will be applied on the latest dev and will be minor so there should be no issue
- πΊπΈUnited States dcam
Ok, I guess there is also concern due to the "(not recommended)" message, which indicates perhaps not properly working.
Using the latest version from the CDN is not recommended because the maintainer can and will release backward-incompatible changes. They've done it before. See the release notes for version 4.0.0 of the module β . By all means go ahead and use it, but you do so at your own peril.
- πΊπΈUnited States in0ni
Ok, understood -- yes best to keep on the 3.x branch and not use a pointer to any major release.
I'm a bit stuck with how to move forward with this, and need your assistance to at least get an idea. We have two options:
OPTION 1 (ideal) I patch the latest release (3.9.7), but this is only worth it if the module will support it.
OPTION 2 I patch the recommended release (3.8.18), only for this project and host our patched versionIn order to proceed, it would help to know if support for 3.9.x would be feasible and a ball-park estimate as to when. This way we can determine if we just wait for support and go with OPT #1, or if we have to go with OPT #2
- πΊπΈUnited States in0ni
Hello @dcam,
Wondering if you are able to provide a rough estimate so we may decide which route to go with. Greatly appreciate it, again if possible I can try to provide assistance.
- πΊπΈUnited States dcam
I added support for 3.9.7. If that doesn't work for you, then you can always download the library and serve it from your local files.
I'll put out a new release shortly.
- πΊπΈUnited States in0ni
This is great, thank you!
I will work on the patch, if and when accepted, surely will be a minor release and at that point can contribute a simple PR for the minor version. Automatically closed - issue fixed for 2 weeks with no activity.