- Issue created by @m.stenta
- πΊπΈUnited States m.stenta
Opened an MR that adds a basic
.gitlab-ci.yml. It setsOPT_IN_TEST_CURRENTto0because we don't support Drupal 11 yet (see π Automated Drupal 11 compatibility fixes for jsonapi_schema Needs review ), and setsOPT_IN_TEST_PREVIOUS_MAJORto1to run tests (just linting) against Drupal 10.composer-lintandeslinttests pass, butcspellandphpcsdo not. Setting to Needs Work to work on those. - πΊπΈUnited States m.stenta
There are two misspelled words flagged by
cspellCSpell: Files checked: 27, Issues found: 5 in 5 files. The number of distinct unrecognised/misspelled words is 2 ------------ millisec shema ------------"
shema" is fixed by #3324620: Fix plugin ID typo: s/shema/schema/ β and "millisec" is fixed by #3246251: Change format "utc-millisec" to "date-time" β , so I think we can hold off on fixing those here. - πΊπΈUnited States m.stenta
Pushed a bunch of commits that fix all
phpcswarnings and errors.They are almost entirely comment and whitespace changes.
It's also an opportunity to run
phpstanIt seems that
phpstanisn't running automatically. I am going to punt that out to a separate issue.This should be ready to merge.
-
m.stenta β
committed ed083e42 on 8.x-1.x
Issue #3523994: Add .gitlab-ci.yml and fix PHP CodeSniffer errors/...
-
m.stenta β
committed ed083e42 on 8.x-1.x
-
m.stenta β
committed be49b71f on 8.x-1.x
Issue #3523994: Add .gitlab-ci.yml
-
m.stenta β
committed be49b71f on 8.x-1.x
- πΊπΈUnited States m.stenta
It seems that
phpstanisn't running automatically. I am going to punt that out to a separate issue.Created a follow-up issue: π Fix PHPStan errors Active
Automatically closed - issue fixed for 2 weeks with no activity.