- Issue created by @jonathan1055
- 🇬🇧United Kingdom jonathan1055
To demonstrate the situation as-is I creatd a new GTD merge request MR17.
Setting
OPT_IN_TEST_CURRENT: 0
to just test PHPunit with the Max PHP variant, the pipeline still runs phpunit at 'current'
https://git.drupalcode.org/project/gitlab_templates_downstream/-/pipelin...Adding
SKIP_PHPCS:1
, the phpcs job is correctly removed, but we still wrongly get two composer jobs and two phpunit jobs
https://git.drupalcode.org/project/gitlab_templates_downstream/-/pipelin...With a change to a test file we also get the 'test-only' job, which is wrong as this should only be run with 'current' variant (as is done in D10+)
https://git.drupalcode.org/project/gitlab_templates_downstream/-/pipelin...Then switching this branch to be tested via MR361, by modifying the '→ GTD D7 Composer' job project and branch
https://git.drupalcode.org/issue/gitlab_templates_downstream-3503337/-/p...
This is correct - we only get composer and phpunit for 'max php version' and no 'test-only changes'So this is ready for review
- 🇪🇸Spain fjgarlin
The changes here look good. NW just to revert the GTD project/branch to use, otherwise it'd be RTBC.
- 🇬🇧United Kingdom jonathan1055
Thanks. I've reverted the last commit.
That MR17 can stay open for future use in scenarios like this. I think in general we want all GTD branches to have
OPT_IN_TEST_CURRENT: 1
but it's easy enough to use a Merge Request for scenarios like this. - 🇪🇸Spain fjgarlin
Yup, makes sense to have MR17 as wildcard for these things.
RTBC.
-
fjgarlin →
committed fe2bf01c on main authored by
jonathan1055 →
Issue #3523652 by jonathan1055, fjgarlin: Add missing opt-in-current-...
-
fjgarlin →
committed fe2bf01c on main authored by
jonathan1055 →
Automatically closed - issue fixed for 2 weeks with no activity.