Contrib.social

Webform conditional logic breaks when a referenced element is deleted

Open on Drupal.org →
Created on 8 May 2025, 7 months ago

Problem/Motivation

When a webform element is removed, any conditional logic (states, visibility, required conditions, etc.) that references this deleted element remains in the webform configuration. This leads to broken behavior such as required fields not being enforced or elements not being shown/hidden as expected. There is no warning or automatic cleanup of conditions referencing non-existent elements.

This can cause significant issues in production forms if element removal is not carefully audited.

Steps to reproduce

  1. Create a webform with the following elements:
    • Element A (e.g. a select or checkbox)
    • Element B (e.g. a textfield), which has a state condition based on Element A
  2. Save the webform.
  3. Edit the webform and delete Element A.
  4. Save the webform again.
  5. Observe that Element B's condition is now broken: it may no longer appear, or it might not be required even though it should be.

Proposed resolution

  • When an element is deleted from a webform, scan the form for any conditions or states referencing it, and either:
    • Automatically remove those conditions; or
    • Warn the user that other elements depend on the deleted one and require manual review.
  • Optionally add validation that blocks saving if a condition references a non-existent element.

Remaining tasks

  • Confirm behavior with multiple element types and nested structures.
  • Write patch or update relevant form builder logic.
  • Add test coverage for deleting elements with dependencies.
  • Update documentation, if needed.

User interface changes

  • Warning or confirmation message when deleting an element that is referenced by conditions.

API changes

  • None expected unless utility methods are added for dependency scanning.

Data model changes

  • None expected.
🐛 Bug report
Status

Active

Version

6.3

Component

Code

Created by

🇵🇱Poland jorgik

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @jorgik
  • Status changed to Needs review 5 months ago
  • Comment 5 months ago →
    🇮🇳India saiprasad_g

    This patch enhances the Webform::deleteElement() method to automatically remove any #states conditions referencing deleted elements, clean up related submission data, and notify administrators of affected fields. It also updates the UI confirmation message to clearly warn that all related conditions will be removed.
    Steps to Reproduce (Before Patch)
    Create Webform with:
    Element A (e.g., checkbox or select)
    Element B ,C,D(e.g., textfield) with a visibility condition on Element A, if Element A checked.
    Save the Webform.
    Delete Element A and save.
    Observe that Element B,C,D still has broken #states, resulting in incorrect visibility.

    Steps to Verify (After Patch)

    Delete Element A.
    All references to it in conditions (#states) across the form will be removed.
    A warning appears listing affected fields whose conditions were cleaned.
    A warning appears listing affected fields whose conditions were cleaned.

  • Comment 4 months ago →
    🇺🇸United States jrockowitz Brooklyn, NY

    I am very hestitant to alter #states logic of elements when an element is deleted.

    I am not sure this is major issue for most sites and might not be worth addressing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024