Update PHPStan to 2.1.13

📌 Bump PHPStan and family to latest versions Active is ready and an intermediate step.

Oh thanks, hadn't seen that one!

2.1.14 released today.

On this.

composer update mglaman/phpstan-drupal phpstan/extension-installer phpstan/phpstan phpstan/phpstan-deprecation-rules phpstan/phpstan-phpunit

Removing the bleedingEdge setting as PHPStan 2.1.13 introduced Report @internal symbols usage from outside their top namespace as a bleeding edge feature. We do not have currently a case for bleeding edge being active, so IMHO we can defer a decision on what to do with the @internal rules (also, maybe PHPStan will evolve there too).

How annoying. Hitting again 🐛 @phpstan-ignore-next-line annotation collides with PHPCS Active

How about

/**
 * Provides render element that extends deprecated FormElement for testing.
 */
#[FormElement('deprecated_extends_form')]
// @phpcs:disable Drupal.Commenting.ClassComment.WrongStyle
// @phpstan-ignore class.extendsDeprecatedClass
class DeprecatedExtendsFormElement extends FormElementDeprecated {

which seems slightly less painful, but not much.

Works for me, thanks.

Rebased, merge conflicts solved for composer files. No changes. Back to RTBC.

I wonder if we need a coding standards or coder rule change to automatically ignore phpstan ignores when considering other rules, having to add the phpcs ignore around the phpstan ignore is... quite annoying.

Other than that (which is not the fault of the MR), all looks good. Committed/pushed to 11.x, thanks!

catch → closed merge request !12019

... a coding standards or coder rule change ...

see #3516489-6: @phpstan-ignore-next-line annotation collides with PHPCS → with link to an upstream PR by @jonathan1055. That would be sufficient IMHO.

Oh nice thanks for the link.

Automatically closed - issue fixed for 2 weeks with no activity.