- Issue created by @nicxvan
- @nicxvan opened merge request.
- 🇨🇭Switzerland berdir Switzerland
Pretty straightforward now, one test .module file less.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇳🇿New Zealand danielveza Brisbane, AU
It's best not to RTBC issues that you've worked on and instead have another person review and mark it as RTBC.
In this case I've reviewed and I'm happy for this to be RTBC.
- 🇨🇭Switzerland berdir Switzerland
@danielveza: This was a re-RTBC after the MR needed a reroll, that's perfectly fine if there weren't any complicated resolutions. See also recent adjustments to the docs on how to set RTBC: https://www.drupal.org/node/3156237/revisions/view/13965063/13985848 → , sometimes we are/were a bit too strict with our rules around that.
- 🇬🇧United Kingdom catch
Yep re-RTBCs of issues after re-rolls are fine, although it's also good to add a comment to explain that's what's happening.
Committed/pushed to 11.x, thanks!