Broken path due to info file being read incorrectly

Thanks for reporting, it is definitely a bug! We'll look into it.

Possible workarounds for now are to set the variable as you did or to remove the single quotes.

Untested, but ready for review.

I managed to make the tests go green using the workaround, so that seems to confirm my findings. Is there a way for me to test this on a specific Group issue MR?

Yup, you'd just need to change the project and ref value in your .gitlab-ci.yml file point to this fork and branch and you'd be testing the change.
https://project.pages.drupalcode.org/gitlab_templates/info/testing-mrs/

Okay, pushed a commit with those instructions.

Yes, thanks for reporting this. When I added that chnage I never considered the project type to be in quotes, but as you say, it is valid.
In your original pipeline we can see PROJECT_NAME=group, PROJECT_TYPE='module' with the quotes.

Can you give a link to the pipeline where you are testing with this MR? We can also test with our downstream projects, which might actually be useful, so that we cover more edge-cases like this.

I think he's trying in this issue: https://git.drupalcode.org/project/group/-/merge_requests/204/diffs

I have just pushed this change in GTD d10-plus, so if we run that downstream pipeline it should pass when using this MR

Running: https://git.drupalcode.org/project/gitlab_templates_downstream/-/pipelin...

Weird, we can see the quotes in the output but it seems to think that it's an ok-name 🤷

Regardless, the change on this MR still makes sense in my opinion.

The change in this MR is definitely the right thing to do.

Regarding the passing phpunit tests, I think this problem only affects jobs running concurrent=1 (and hence using run-tests.sh) which is what we have in Max PHP version. The parameter there is --directory 'module's/custom/gitlab_templates_downstream which causes the error. With concurrent=0 (which is what we have in d10-plus 'current') the arguments is just the path the project i.e. /builds/project/gitlab_templates_downstream/web/'module's/custom/gitlab_templates_downstream and the phpunit binary can cope with this. Quotes are valid characters in the directory path, although I'm sure most people avoid them :-)

Downstream d10-plus has the project type the quotes
https://git.drupalcode.org/project/gitlab_templates_downstream/-/jobs/51...
So this is RTBC

Just for good measure I have also change phpunit (previous minor) to run concurrent=1 and now we see a proper red failure, when running against the default-ref
https://git.drupalcode.org/project/gitlab_templates_downstream/-/pipelin...

Great, thanks for the additional testing and the extra digging.
Merging this. Thanks for reporting and testing!

All green on the Group issue when using 'main' branch of gitlab_templates :)