- Issue created by @vishalkhode
- Merge request !960Draft: Fixed Typed property error when rendering Image component with media library selection. → (Open) created by vishalkhode
- 🇺🇸United States mglaman WI, USA
Looks good to me, fixes a bug with private properties and DependencySerializationTrait
- 🇺🇸United States phenaproxima Massachusetts
I've run into this before, and making the property
protected
is the correct fix, but I'd suggest putting a comment about why that's the case, because unless you have the context (and the willingness to debug the craziness of DependencySerializationTrait), putting aprotected
member in afinal
class looks like a mistake. - 🇮🇳India meghasharma
Added comments explaining why the properties are protected to support DependencySerializationTrait.