- Issue created by @scott_euser
- π¬π§United Kingdom scott_euser
Small change, but will at least be helpful for future me and perhaps other devs
phpstan issue unrelated and occurs on 2.x
- πΊπΈUnited States cmlara
For the 2.x we are embracing using GitLab Pages for the documentation/manual. This is rendered by mkdocs from the markdown files in the docs folder and published on each 2.x pipeline execution. It is also currently included in each download for offline viewing.
We likely should place this somewhere in the docs (there may be no great location for it at the moment as they are sparsly populated, a new section may be necessary).
I'm going to set back to NW for including in the
For REST logins I would suggest sites I would recommend the site owner consider using an API token auth provider (unless we are talking about the post login to obtain a cookie).
This will impact password access that uses the
user.auth
service to validate a use. Known scenarios this is relevant for:- Password confirmation forms that do not check the database directly
- HTTP Post to /user/login (this is always enabled in Drupal Core).
- http_basic authentication
Given the above not sure it if makes sense to limit this to just the
rest
module enabled.To me it feels a bit unusual to inline this, though at the moment it is indeed not documented anywhere except in the deep issues logs.
- π¬π§United Kingdom scott_euser
scott_euser β changed the visibility of the branch 3521300-document-tfa-and-rest to hidden.
- π¬π§United Kingdom scott_euser
Makes sense and thank you for the detailed explanation. I added a documentation page nested within configuration with options + tried to capture your recommendation with examples.
- πΊπΈUnited States cmlara
Looks good.
I did add the new page to the menu above exempting authentication provides.
Minor suggestion on possible text change to be a bit more agnostic on providers provided in text.
- π¬π§United Kingdom scott_euser
Sorry was slow getting back to you here! Thanks for resolving, after the changes the wording is clear and would help future travellers trying to figure out how it works.
And thanks for the great module overall, much appreciated!
- πΊπΈUnited States cmlara
Thanks for the confirmation you find the suggested tweaks acceptable.
Committing MR!129 to Dev (should show up on GitLab pages in a few minutes).
Do you find the documentation pages sufficient that we can also close out MR!126?
-
cmlara β
committed d0b128b8 on 2.x authored by
scott_euser β
Issue #3521300 by scott_euser, cmlara: Document how to use TFA with REST
-
cmlara β
committed d0b128b8 on 2.x authored by
scott_euser β
- πΊπΈUnited States cmlara
Thank you for confirming.
Closing the issue out as fixed.
Thank you again for the primary work on this commit.
This is the rendered page:
https://project.pages.drupalcode.org/tfa/configuration/tfa-with-rest/ Automatically closed - issue fixed for 2 weeks with no activity.