Update base styles scaling for fonts, margins, etc - based on canonical figma style guide

Created on 24 April 2025, 3 months ago

This ticket is to ensure base font styles and content margins on the Bluecheese thme match the Current Figma Styleguide

πŸ“Œ Task
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States biz123

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @biz123
  • Merge request !170Resolve #3521079 "Update base styles" β†’ (Merged) created by biz123
  • Pipeline finished with Success
    2 months ago
    Total: 159s
    #501291
  • Pipeline finished with Success
    2 months ago
    Total: 146s
    #501293
  • Pipeline finished with Success
    2 months ago
    Total: 148s
    #502324
  • Pipeline finished with Success
    2 months ago
    Total: 250s
    #502403
  • Pipeline finished with Success
    about 2 months ago
    Total: 146s
    #514719
  • Pipeline finished with Success
    about 2 months ago
    Total: 150s
    #514724
  • Pipeline finished with Success
    about 2 months ago
    Total: 151s
    #514738
  • Pipeline finished with Success
    about 2 months ago
    Total: 148s
    #514745
  • Pipeline finished with Success
    about 2 months ago
    Total: 154s
    #514749
  • Pipeline finished with Success
    about 2 months ago
    Total: 237s
    #514750
  • Pipeline finished with Success
    about 2 months ago
    Total: 150s
    #515514
  • Pipeline finished with Success
    about 2 months ago
    Total: 147s
    #515528
  • Pipeline finished with Success
    about 2 months ago
    Total: 133s
    #515606
  • Pipeline finished with Success
    about 2 months ago
    Total: 144s
    #515619
  • Pipeline finished with Success
    about 1 month ago
    #532438
  • Pipeline finished with Success
    about 1 month ago
    Total: 243s
    #532635
  • Pipeline finished with Success
    about 1 month ago
    Total: 243s
    #533422
  • πŸ‡ΊπŸ‡ΈUnited States mherchel Gainesville, FL, US

    I looked over the code, issue, and looked through the changes

    A couple notes:

    • This is a large MR
    • Lots of order changes, which muddies things up
    • Most of the work is in css/base/basic-elements.css and changing the global-text class to wysiwyg
    • I don't see anything within the code that's going to break anything.
    • Looking visually, I don't see any obvious regresssions

    My initial thought is that because 1) This MR has been open for two months and there's a lots of reorganization, this should be merged, because it will hold up other changes.

    We should also do a followup to convert the old-style CSS to use nesting.

    Not yet setting this to RTBC, because not sure if @biz123 thinks its ready (it's not set to review).

  • πŸ‡ΊπŸ‡ΈUnited States mherchel Gainesville, FL, US
  • πŸ‡ͺπŸ‡ΈSpain fjgarlin

    In the feedback round, it was mentioned that font size was still too big. Are we addressing this here?

  • πŸ‡ͺπŸ‡ΈSpain fjgarlin

    This MR left, prod on the right.

  • πŸ‡ΊπŸ‡ΈUnited States mherchel Gainesville, FL, US

    Good catch!

    @biz123 - Let me know if you're still actively working on this. If not, I'm happy to help

  • Pipeline finished with Success
    24 days ago
    Total: 148s
    #543565
  • Pipeline finished with Success
    24 days ago
    Total: 172s
    #543592
  • Pipeline finished with Success
    24 days ago
    Total: 150s
    #543606
  • Pipeline finished with Skipped
    18 days ago
    #548301
  • πŸ‡ͺπŸ‡ΈSpain fjgarlin

    We need to create follow-ups, but the current MR can be merged.

  • πŸ‡ͺπŸ‡ΈSpain fjgarlin

    fjgarlin β†’ changed the visibility of the branch 2.x to hidden.

  • Pipeline finished with Skipped
    17 days ago
    #549191
    • fjgarlin β†’ committed 5e5aa158 on 2.x
      Issue #3521079 by biz123, fjgarlin, mherchel: Update base styles scaling...
  • πŸ‡ͺπŸ‡ΈSpain fjgarlin

    Follow up for menu in Safari merged.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024