- Issue created by @riya.gandhi@designbysoapbox.com
- Merge request !78Bugfix for footnotes module when it's placed inside <details> element → (Merged) created by Unnamed author
- 🇬🇧United Kingdom scott_euser
Thanks, looks good - I wonder however whether we should add this to the end of the
<body>
(appended inside it) in case<details>
is subsequently wrapped in something else that is collapsed?Beyond that just some coding standards clean-up flagged (see merge request > pipeline warning for eslint, in the right side when viewing the failure on desktop is a download button that will contain an _eslint.patch you can apply to your merge request).
Thanks! Is the latest update what you were after?
-
scott_euser →
committed 98e97af0 on 4.0.x authored by
riya.gandhi@designbysoapbox.com →
Issue #3520970 by riya.gandhi@designbysoapbox.com: Footnotes within...
-
scott_euser →
committed 98e97af0 on 4.0.x authored by
riya.gandhi@designbysoapbox.com →
- 🇬🇧United Kingdom scott_euser
Nice one, thanks Riya! This will be part of next release, so you can continue to use the patch from the MR diff for now.