While testing, I've noted two different, related issues:
For both, install the module, and place the block in a region on one or more nodes.
This is probably not reproducible everywhere (see below).
The form submits.
The form submits; even when a message is provided, it's not recorded in the feedback view.
There are two different things at play here:
edit-feedback-send--2For (1) the solution is to replace all instances of #edit-feedback-send with something that will not change like .feedback-btn__send-comment or [data-drupal-selector='edit-feedback-send'].
For (2) the solution is one of:
$("#edit-feedback-send").prop("disabled", true);, to just before the click handler, or even better, remove the line from javascript altogether and'disabled' => TRUE, to the form attributes array in AdminFeedbackAjaxForm.phpTogether, these changes mostly fix the original two issues--I'm still trying to understand why mousedown events on the "Send feedback" button are able to submit the form.
Find out why mousedown is enough to submit the form, address that, and create an MR :)
N/a
N/a
N/a
Active
2.7
User interface
Turns out that $form['feedback_send']['#ajax']['event'] should be set to "click".
Browsing the code, I also notice other selectors that are likely to suffer the same fates in some circumstances. E.g. #feedback-msg-answers--2 wouldn't be fixed by this MR.