Trash Not Compatible With Feeds

I spent a few days debugging the issue and determined that the Trash module was causing mayhem with Feeds.

What mayhem though? I think this needs more specific steps to reproduce. What exactly was the issue? (I know this is a couple months old and may not be fresh on your mind anymore!)

Here's what I did:

1. Tested on a site with Feeds and Trash enabled
2. Created a feed type to import from an RSS feed on some other website to a content type that had Trash enabled
3. Ran the importer which imported a bunch of nodes
4. Deleted one of the nodes (moved it to trash)
5. Re-ran the importer
6. Observed that the importer imported the trashed node again

This is what I expected would happen. When feeds went to check if the node already existed or not, it found that it did NOT exist because it was in the trash and the Trash module is "hiding" it from anything that goes looking for it.

The problem is that Feeds needs to notify the Trash module to "ignore" the deleted flag. Thankfully, Trash provides just such a way by using this code:

    \Drupal::service('trash.manager')->setTrashContext('ignore');
    $query->addTag('ignore_trash');

I added this to the method `\Drupal\feeds\Plugin\Type\Target\FieldTargetBase::getUniqueValue` near line 227, re-ran the import, and the deleted nodes were no longer included.

--

I'm not sure what the best course of action here is, since we're talking about two contrib modules.

I discussed with partyka and we think this is actually not a problem and the issue can be closed. At the very least, this should have more clearly defined description of what the problem is.

It sounds like what really is the problem is that the act of deleting and re-importing nodes created a ton of stuff in the trash with no clear way to purge the trash. Trash should have a purge all functionality or a multi-select for purging as was suggested in the issue summary.

But the current behavior I think makes sense, as I outlined in #6. An alternative behavior would be if Feeds didn't re-import items that were already trashed, but I think that's even more confusing.