Case-sensitive tokens

That's an interesting one. I wonder if the token API has any documentation about the keys being lowercase, of if we just assumed that would be what's happening? Wasn't able to find any such documentation, and assume that we've been too cautious here. Mixed case token keys should be perfectly OK. So, I tend to lean towards option 2, combined with a warning in the release notes that this may break existing models.

So, I tend to lean towards option 2, combined with a warning in the release notes that this may break existing models.

Agreed

MR is ready for review. I've also changed the issue title so that the breaking change will be visible in the release notes.

Thanks. While the code change looks exactly as described, there is a failing test which may require some attention: https://git.drupalcode.org/project/eca/-/jobs/5327402

Setting to NW due to the failed test.

Yeah, just saw that and fixed the existing test as well as appended a new test, so that we can test both cases: if the case of the token is equal and if it's not.

Looks great, thanks!

Merged. I guess this shouldn't be back ported, though.