Remove constructors and extra constructor parameters from Controllers and Form classes

Created on 16 April 2025, 21 days ago

Problem/Motivation

In ✨ Deprecate passing extra parameters to __construct() to prepare for 3.0.x Active and [#] we deprecated the arguments and constructors on a number of classes. Once we are on the 3.0.x branch of development, we will remove these arguments and constructors entirely.

Note that I've assigned this to 2.x-dev version for now, since the 3.0.x branch doesn't yet exist. This issue is blocked on creating that new branch in ✨ Drop support for D8, D9, D10.0-10.3 Active .

Proposed resolution

Remove the unnecessary constructors from the following classes:

\Drupal\structure_sync\Controller\MenuLinksController::__construct()
\Drupal\structure_sync\Form\BlocksSyncForm::__construct()
\Drupal\structure_sync\Form\MenuSyncForm::__construct()
\Drupal\structure_sync\Form\TaxonomiesSyncForm::__construct()

Remaining tasks

Write a merge request to remove the constructors from these classes.
Review and feedback
RTBC and feedback
Commit

User interface changes

None.

API changes

None.

Data model changes

None.

✨ Feature request

Status

Active

Version

2.0

Component

Code

Created by

🇨🇦Canada spiderman Halifax, NS

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @spiderman
Comment 16 days ago →
🇨🇦Canada mparker17 UTC-4
Going to mark ✨ Deprecate the constructors in BlocksController, TaxonomiesController, and MenuLinksController Active as the parent of this issue, because we have to do that one first :)

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024