- Issue created by @mitrpaka
- Merge request !156Fix bitwise operator usage and remove redundant is_array check → (Open) created by mitrpaka
While working with #3518675, I noticed that redirectLogout() function uses bitwise operator (&) instead of logical operator (&&) while checking if any client names returned for this user based on its username. As this appears to be a typo, I've created a separate issue to ensure it is fixed sooner rather than later :-)
https://git.drupalcode.org/project/openid_connect/-/blob/3.x/src/Control...
The getAll() method from the external authmap service is expected to return an array. Therefore, the
is_array check is redundant and can be removed.
// Before
if (is_array($mapped_users) & !empty($mapped_users)) {
// After
if (!empty($mapped_users)) {
Active
3.0
Code