- Issue created by @keiserjb
- π³πΏNew Zealand danielveza Brisbane, AU
I've just run into this as well, it would be good to get this committed if we no longer need to support v1. Otherwise we might need to alter the if statements to check both v1 and v2.
I wonder if we can turn these into plugins or do something a little nicer than elseifs checking strings. But I think thats something to think about later.
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
I think this is critical as the Titan V1 embedding model doesn't work at all.
- First commit to issue fork.
- π©πͺGermany marcus_johansson
Its a general problem with AWS that each model works differently, so we have to map the configuration into their own class. There is no record of them deprecating the old model, but I could replicate the issue that its not listed as a on-demand model anymore at least.
I did a small fix to the code from @danielveza, thank you. As soon as that is approved I will push a new version of both 1.0.x and 1.1.x versions.
As a note - in general we are looking for maintainers for any provider module, so if you are using it and want to be a maintainer let us know.
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Thanks @marcus_johansson. Can't speak for @danielveza but I will put my hand up for maintainership.
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
I like @danielveza 's idea of
I wonder if we can turn these into plugins or do something a little nicer than elseifs checking strings.