Improvements in log output, consistency in syntax, alignment with D7

These changes have the potential to conflict with existing MRs but apart from the documentation MR there are currently only 3 other open and active MRs (where active = worked on in the last month) so now is a good time to do this. Those other earlier MRs will already be out of date and probably have conflicts.

I will make the changes in sequence, and keep them in separate commits for easier reviewing.

The first one was actually already done (I had not updated my notes). So there are only five proposed changes.

First three changes done.

Good improvements here. Thanks for working on them.

Thanks. I have pushed changes for items 4 and 5 and this is ready for review and feedback.

Just to note (I'm sure you knew this already) that the syntax needs: [composer (next minor)] if perfectly valid without the quotes even when there are multiple words. So I did not add quotes, just to keep it cleaner, but if you don't like the look of it I can add them. ESlint/Prettier demands no spaces between [ and the first character, and if using quotes they have to be singles not doubles.

The D7 downstream pipeline yesterday failed for phpcs and phpunit, but the problem seems to be in the Composer jobs (but not anything changed in this MR). We get an odd error when trying the symlink

$ php symlink_project.php "$CI_PROJECT_NAME" "$DRUPAL_PROJECTS_PATH"
Retry later

See https://git.drupalcode.org/project/gitlab_templates_downstream/-/jobs/49...
I note that we do not have a $COMPOSER_END_CODE check in D7 like we do for D10, so I think this needs to be added. It would highlight this error in the Composer job, and not give misleading info about phpcs or phpunit failures. But that is for another issue, as it will need separate testing.

Thanks for the changes. I'm fine with not having quotes if it's valid syntax.
Rest of the downstream pipelines: https://git.drupalcode.org/issue/gitlab_templates-3518579/-/pipelines/47...

Everything seems ok and it should not change anything really in the outcome of jobs, so I'll merge this shortly.

Merged!

Wow, that was one of the quickest MR commits. I was about to upload this screenshot to demonstrate what I meant about the 'find all'. So here it is, just for the record. Thanks for the merge.

🙂

I knew perfectly what you meant by that, I usually do these type of searches as well and then need to iterate to see the detail, so this is really helpful to see the context straightaway.

Automatically closed - issue fixed for 2 weeks with no activity.