- Issue created by @tedbow
- 🇺🇸United States tedbow Ithaca, NY, USA
One thing I don't understand is because `\Drupal\experience_builder\EventSubscriber\RenderEventsSubscriber::getSubscribedEvents` and `\Drupal\block\EventSubscriber\BlockPageDisplayVariantSubscriber::getSubscribedEvents` both subscribe to `RenderEvents::SELECT_PAGE_DISPLAY_VARIANT` but don't set a priority what guarantees that `RenderEventsSubscriber` will 2nd ? If BlockPageDisplayVariantSubscriber ran 2nd wouldn't it just overwrite RenderEventsSubscriber settings?
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
#3: hah, nice catch! I think that's indeed only working thanks to XB's module name starting with
e
, and Block withb
, and hence XB's event subscriber running later 😅We should specify a priority in
\Drupal\block\EventSubscriber\BlockPageDisplayVariantSubscriber::getSubscribedEvents()
:) - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
+1'd @tedbow's latest idea on the MR, this now seems close!
- 🇺🇸United States tedbow Ithaca, NY, USA
Tests were failing. I think I have fixed them
If so, I think this issue is good to go