- Issue created by @dieuwe
- 🇳🇿New Zealand dieuwe Auckland, NZ
Modules that have been temporarily removed from the 11.0.x branch:
- sector_theme (due to a dependency on material_icons)
- sector_external_links
Permanently removed:
- material_icons (it's required by the theme, so no need to have it twice)
There are a few failing patches too:
- https://www.drupal.org/files/issues/2024-07-26/3328425-44.patch →
- https://www.drupal.org/files/issues/2024-08-21/3274635-mr5079-94fde602-1... →
That's not a bad start.
-
dieuwe →
committed adfba175 on 11.0.x
Issue #3517857: Prepare for Sector 11 by updating patches
-
dieuwe →
committed adfba175 on 11.0.x
- 🇳🇿New Zealand dieuwe Auckland, NZ
We're down to just material_icons not having 11 support. I've added composer lenient to the template project (check that out for how to allow composer to install it anyway on a per-project basis.)
Both those patches are still failing. The first should be compatible with D11 so I am investigating that further, the second looks like it has not be rebased for D11 so will need work.
- 🇳🇿New Zealand dieuwe Auckland, NZ
I've had to remove sector_theme from the distro due to composer lenient only kicking in after the initial "composer install".
It's fine if you're upgrading or adding packages after the initial install, but to keep things simple I have excluded it.
In order to test Sector 11 you can do a fresh install or an upgrade. Fresh install:
composer create-project drupal/sector_project_template:11.x-dev sector composer require drupal/sector_theme > installation process crashes (investigating)
To upgrade an existing project:
composer require mglaman/composer-drupal-lenient composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/material_icons"]' composer require drupal/sector:11.0.x-dev composer require drupal/sector_theme
The second core patch from comment#2 is still failing. All else looks fine.
We need to keep an eye on 📌 Automated Drupal 11 compatibility fixes for material_icons Needs review for material_icons and ✨ [upstream] Use CKEditor 5's native and UX Needs work for that core patch.
- 🇳🇿New Zealand dieuwe Auckland, NZ
To get Material Icons to behave, also temporarily add a patch for it to your project:
"patches": { "drupal/material_icons": { "Drupal 11 compatibility": "https://www.drupal.org/files/issues/2024-03-18/material_icons.2.0.2.rector.patch" } },
- 🇳🇿New Zealand dieuwe Auckland, NZ
On install there are a few PHP deprecation warnings with 8.4 on a handful of contrib modules that I'll follow up on separately with those modules.
Other than that, the fresh install runs smoothly for me, so the Sector 11 dev version is ready for further work.
-
dieuwe →
committed 65af9db1 on 11.0.x
Issue #3517857: Add sector_theme back to Sector 11
-
dieuwe →
committed 65af9db1 on 11.0.x
- 🇳🇿New Zealand dieuwe Auckland, NZ
Workarounds from comment 5 & 6 no longer needed - material_icons is compatible with 11 and sector_theme has been added back.
Still a few things on those core patches to review, so leaving issue open for a bit longer.
-
gareth.poole →
committed 2f0464f3 on feat/rebased-10-to-11 authored by
dieuwe →
Issue #3517857: Prepare for Sector 11 by updating patches
-
gareth.poole →
committed 2f0464f3 on feat/rebased-10-to-11 authored by
dieuwe →
-
dieuwe →
committed 65af9db1 on feat/rebased-10-to-11
Issue #3517857: Add sector_theme back to Sector 11
-
dieuwe →
committed 65af9db1 on feat/rebased-10-to-11
-
dieuwe →
committed adfba175 on feat/rebased-10-to-11
Issue #3517857: Prepare for Sector 11 by updating patches
-
dieuwe →
committed adfba175 on feat/rebased-10-to-11
-
chroid →
committed 735dae37 on 11.0.x authored by
dieuwe →
Issue #3517857: Prepare for Sector 11 by updating patches
-
chroid →
committed 735dae37 on 11.0.x authored by
dieuwe →