- Issue created by @huzooka
- ππΊHungary huzooka Hungary ππΊπͺπΊ
I also looked at the docs here https://project.pages.drupalcode.org/gitlab_templates/jobs/phpstan, didn't found anything whick made me think my config is not valid anymore.
- π¬π§United Kingdom jonathan1055
Hi huzooka,
Thanks for reporting this. You say since 21 December, so it is likely that π Tweak PHPStan config so paths are always correct and baseline is more usable Active has something to do with this, as those changes where made default in version 1.6.11 released on 18 December. Just for verification, would you be able to run a test pipeline using version 1.6.10? You can do this via the pipeline UI form. You need to enter the value for_CURL_TEMPLATES_REF
as 1.6.10. This variable is right at the end of the form.Can you give a link to this pipeline, then I can check how the processing differs from the later run. Thanks.
- π¬π§United Kingdom jonathan1055
That third call to phpstan uses
--allow-empty-baseline
which should allow the baseline file to not exist. At least it did when we tested those changes back then.
In your committed 1.8.x repo you just have the default
phpstan-baseline.neon
file, so I was wondering where thecustom-phpstan-baseline.neon
name came from? Did you set this via pipeline UI variable?Looking back through your pipeline history, PHPstan passed '3 months ago' here
https://git.drupalcode.org/project/migmag/-/jobs/3697585Just trying to understand the background of the problem.
- π¬π§United Kingdom jonathan1055
I have replicated your error by using your exact
phpstan-baseline.neon
file in our Gitlab Templates Downstream testing project. Here is the failing pipelineMy understanding is that the baseline file usually has just errors to ignore, not other config parameters. These other config parameters usually go in the project's
phpstan.neon
config file. This may only be a convention of practice, not a rule, but I tried changing the phpstan-baseline.neon file so that it did not contain theexcludePaths
and the job then passed perfectly! Here is the passing pipelineI have opened a new MR on π Fix testing on most recent Drupal core versions Active to test this in your project.
- π¬π§United Kingdom jonathan1055
Migmag MR13 now correctly runs PHPStan jobs.
There is still some investigation required as to why your original
phpstan-baseline.neon
caused the failure.