- Issue created by @maxwhitehead
- Merge request !343Issue #3516958: Update CI image registry (_CONFIG_DOCKERHUB_ROOT) to... β (Merged) created by maxwhitehead
- πͺπΈSpain fjgarlin
Triggering downstream pipelines (there are a few, which is great for testing): https://git.drupalcode.org/issue/gitlab_templates-3516958/-/pipelines/46...
- πͺπΈSpain fjgarlin
Code-wise, it looks good, and the downstream pipelines are running as expected and pulling the images from the new registry.
- π¬π§United Kingdom jonathan1055
Thanks to all here and on Slack for working to solve this.
I have also tested this MR on Scheduler here, and everything works - including loading PHP7.4 for Drupal 8.
RTBC+1 and when merged hopefully we can make a new release soon.
- πͺπΈSpain fjgarlin
Images were pushed to our gitlab.com registry as part of π CI: Push to gitlab.com registry instead of dockerhub (avoid rate limit errors) Active .
Core also made the same changes in π CI: Switch drupalci image registry from dockerhub to gitlab.com (mitigate rate limit errorss) Active .I will merge this now and make it the default for all contrib.
-
fjgarlin β
committed b02cf0aa on main authored by
maxwhitehead β
Issue #3516958 by maxwhitehead, fjgarlin, jonathan1055: CI: Switch...
-
fjgarlin β
committed b02cf0aa on main authored by
maxwhitehead β
- πͺπΈSpain fjgarlin
Merged! Thanks so much for the MR and additional tests.
- π¬π§United Kingdom jonathan1055
Good work. Just for the record, I can see you have released both 1.8.1 and 1.9.0 today, with 1.9.0 as new default. Was this in case there are problems with the new images then people can revert to 1.8.1 but still get those earlier improvements?
- πͺπΈSpain fjgarlin
x.y.z - I usually bump "z" for bug fixes and maintenance tasks. And I usually bump "y" for new features/bigger changes.
I was about to include it as part of 1.8.1, as this could be considered a bug, but I also thought that it was a big-enough change to bump the minor. I kind of followed https://project.pages.drupalcode.org/gitlab_templates/help/contributing/...