- Issue created by @nicxvan
- πΊπΈUnited States nicxvan
I have been thinking about this since I created this and I'm really not sure we should do this.
- π©πͺGermany donquixote
For now we need to target procedural hooks by setting ProceduralCall as the class name, which is awkward.
With π HookCollectorPass registers event listeners but they do not follow the required calling convention Active , which includes π Drop/replace the ProceduralCall class for hooks Active , we drop the class ProceduralCall.We then either need #[ReOrderHook(function: ...)], or we need a separate attribute #[ReOrderProceduralHook($function)] or #[ReOrderHookFunction($function)]. Or we could pass $module instead of $function.
The main argument for a separate attribute would be to keep the other arguments required in the regular #[ReOrderHook] attribute.
In the same way we would need OrderBefore(function: ...) or OrderBeforeProcedural($module)