I've been looking into Layout builder tests in the slow group and trying to improve them. This particular change takes LayoutBuilderDisableInteractionsTest from 2:10 to 1:01 locally
Multiple times in this test, we verify that an element is not clickable by verifying that the exception from DrupalSelenium2Driver::click has been caught. Each time we try catch to this exception, we need to wait the full 10 seconds.
This looks to be the only test that catches the expection as part of this testing, and there should be no BC implications, a new parameter will retain the existing 10 seconds value.
LayoutBuilderDisableInteractionsTestLayoutBuilderDisableInteractionsTest and see test time has been lowered.Add a new optional $timeout parameter to LayoutBuilderDisableInteractionsTest::click with a default value of 10 seconds
New timeout parameter added to LayoutBuilderDisableInteractionsTest::click with a 10 second default value.
Active
11.0 🔥
phpunit
Ah actually. While I was prepping the MR for this it wasn't as easy as I was initially thinking when I opened this because we can't override the click element, and other approaches I was thinking about wasn't as clean as I was hoping for.
Postponing this one so I can think about it a bit more.