- Issue created by @luke.leber
- 🇦🇺Australia acbramley
Definitely should be doing the second proposed solution, there should be defense in that buildForm method for when
$config->get('general_settings.layout_plugins')[$id]returns NULL
This is a related issue to https://www.drupal.org/project/diff_plus/issues/3485245 💬 Warning in first installation Active
There's a bit of an odd design pattern that I've not encountered before with the diff module configuration. Essentially, when a third party module adds a new diff layout plugin type, unless the third party module also adjusts diff.settings:layout_plugins on install, the next time a site owner visits the diff general settings form they'll encounter a pile of warnings:
I'm looking for some upstream guidance here. Thanks!
Now there are a couple ways to approach this problem:
Adjust the diff module settings from a third party module on install
I don't necessarily like this as I've not seen the pattern before. It seems very weird for a module to go and alter other module's settings on install.
Update the diff module settings form to be more lenient and assume that new plugins are disabled by default (and may not yet exist in active configuration).
I do think this is a safer route than making assumptions about weights and such in a third party install hook.
See what the diff maintainers think.
None
None
None
Active
2.0
Code
Definitely should be doing the second proposed solution, there should be defense in that buildForm method for when $config->get('general_settings.layout_plugins')[$id] returns NULL