- Issue created by @mstrelan
- 🇦🇺Australia mstrelan
The fails here are all due to resizing the browser. It seems in 128+ the
window.innerHeight
is always 139px less than the height you resize to. I tried to debug this in non-headless mode, which was even weirder because resizing to 400px wide would set it to 500px width.It seems that the 139px includes the browser chrome (toolbar, infobar, etc), but I'm not sure if the difference is in how the
resizeWindow
works, or in how the browser reportswindow.innerHeight
. Either way, usingwindow.outerHeight
makesBrowserWithJavascriptTest::testJavascript
pass.There was an option to use
--headless=old
which would mean we don't need to refactor any tests, but this has been removed in Chrome 132.I was able to apply the same logic to
LayoutBuilderDisableInteractionsTest::testFormsLinksDisabled
and increase the height by 139px, but it seems like a bit of a hack.Tried the same approach for the Nightwatch tests but it seems like there must be something else going on there.
- 🇦🇺Australia mstrelan
Looks like the random fails we saw in 134 are creeping back in, and we've got a green run on 134 with all the additional waits added, so maybe we should just stick with that.
- 🇬🇧United Kingdom catch
Nightwatch testing has not really been maintained since it was added (apart from in desperation), but there is 📌 Consider dropping Nightwatch in favor of Functional Javascript tests Active .