- Issue created by @pwolanin
This is a meta issue to address the concerns before this is suitable for production. The goal is that this module needs to be at a 1.0 release with security team coverage
Need to update the automated testing so it at least does Drupal 10 and 11 on Gitlab CI, ideally also Drupal 9. See work on jwt module 2.x branch.
Consider renaming the hooks such as hook_ENTITY_TYPE_access_records that may overlap with those provided by the node module. For example, hook_ENTITY_TYPE_grants should at least be renamed hook_ENTITY_TYPE_entity_access_grants and hook_ENTITY_TYPE_access_records to hook_ENTITY_TYPE_entity_access_records or even hook_ENTITY_TYPE_raft_entity_access_records.This would allow this module to be used for node access if desired. The other hooks might also be renamed to make them better namespaced, such as hook_entity_grants β hook_entity_access_grants or even hook_raft_entity_access_grants
Fix some typos and review the accuracy of the api.php docs to match the hook changes and for clarity on how the system works.
Review and update the README including the TODOs there.
Add a drush command or console command to rebuild the access records for a given entity type.
Remove reference to RAFT-4963 in the code and define the cache context needed in alterQueryForType()
Expand on the existing automated tests - the current Kernel test should have some more cases and possibly add a functional test to check that jsonapi and a Views REST display all give correctly filtered results for the current user.
Potentially add a second test module that adds additional access records and grants and make sure they combine as expected. For example role-based realms possibly as a simple way to test something that looks like group-based realms
Active
1.0
Code