- Issue created by @andyg5000
- πΊπΈUnited States andyg5000 North Carolina, USA
Disregard this one!
I see that it's supposed to be grabbing Gtags and not GTMtags for the default.
getDefaultTagId() appears that it should be checking for the first GTM code in the list to match GOOGLE_TAG_MANAGER_MATCH regex. However, the condition is === 0 meaning that it will return the first code that doesn't match the regex of GOOGLE_TAG_MANAGER_MATCH
I believe the condition should be === 1 and the first code in tests should be 'GTM-XXXXXX' instead of 'GT-XXXXXX'
Change the unit test to 'GTM-XXXXXX' in PageAttachmentsHookTest::testAttachments and see it fail.
Change the condition and update the tests to use the correct code.
Review the incoming merge request
Active
2.0
Code
Disregard this one!
I see that it's supposed to be grabbing Gtags and not GTMtags for the default.