Move MARK_* constants from theme.inc into Enum in History module

Created on 19 March 2025, 24 days ago

Problem/Motivation

After 📌 Deprecate node_mark Active the only use of MARK_READ MARK_NEW and MARK_UPDATED is the history module. We don't need these constants in core's theme.inc file. They can be in a new Enum in the History module.

Proposed resolution

Deprecate constants
Create new enum in history module
Swap usages of constants in core to enum

Remaining tasks

User interface changes

None

Introduced terminology

None

API changes

MARK_* constants deprecated
New enum in history module

Data model changes

None

Release notes snippet

📌 Task
Status

Active

Version

11.0 🔥

Component

base system

Created by

🇦🇺Australia acbramley

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @acbramley
  • 🇨🇭Switzerland berdir Switzerland

    the constants are passed to the mark template. They are defined by it and that's why they are in theme.inc. both node and history module are just using them, not owning them.

    That makes BC really challenging with an enum and moving it, we'd need completely deprecate and replace the theme hook, but that would break anyone using it.

  • 🇦🇺Australia acbramley

    the constants are passed to the mark template

    Oh gosh I didn't realise that, I hadn't done a full grep for the constants just a CTRL+Click in PHPStorm to find usages of it.

Production build 0.71.5 2024