[pp-2] Clean up method default to use NULL for Hook Attributes

Created on 19 March 2025, 15 days ago

Problem/Motivation

#3479141-52: Implement FormAlter and Alter attribute β†’ FormAlter uses '' for the method argument because Hook does. I don't think there is a good reason for that so we can clean that up before 11.2.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Active

Version

11.0 πŸ”₯

Component

base system

Created by

πŸ‡ΊπŸ‡ΈUnited States nicxvan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @nicxvan
  • πŸ‡¨πŸ‡­Switzerland berdir Switzerland

    FWIW, Hook is a class that exists in 11.1, there are likely no subclasses yet, but changing the type like that is a technically a BC break. So will need a decision on whether that's important enough to warrant that or this is a won't fix.

  • πŸ‡ΊπŸ‡ΈUnited States dww

    Thanks for opening this issue based on my feedback at #3489141.

    Sad panda. I wish we were consistent with this sort of thing. It's too bad we released Hook with this slightly weird DX. It's definitely minor, no real harm done the way it is, other than the mild WTF.

    If this is "[PP-2]", it should be postponed, and the summary should say what it's blocked on.

    Thanks,
    -Derek

Production build 0.71.5 2024