- Issue created by @jonathan1055
- Assigned to jonathan1055
- 🇬🇧United Kingdom jonathan1055
We need this now, because 📌 Exclude node_modules folder from artifacts Active makes changes to the Stylelint job, but we have no downstream test coverage of this.
- 🇬🇧United Kingdom jonathan1055
jonathan1055 → changed the visibility of the branch 3513408-test-coverage-for-stylelint to hidden.
- Merge request !26#3513408 Add style.css to provide Stylelint test coverage → (Merged) created by jonathan1055
- 🇬🇧United Kingdom jonathan1055
Tested via UI with new variable
BEFORE_SCRIPT_ACTIONS
set to stylelint-fail, and the job fails as required.
https://git.drupalcode.org/issue/gitlab_templates_downstream-3513408/-/j... -
jonathan1055 →
committed 520125b0 on d10-plus
Issue #3513408 by jonathan1055: Add test coverage for stylelint job
-
jonathan1055 →
committed 520125b0 on d10-plus
-
jonathan1055 →
committed d698721c on d10-theme
Issue #3513408 by jonathan1055: Add test coverage for stylelint job
-
jonathan1055 →
committed d698721c on d10-theme
-
jonathan1055 →
committed 3cbc82f1 on d9-basic
Issue #3513408 by jonathan1055: Add test coverage for stylelint job
-
jonathan1055 →
committed 3cbc82f1 on d9-basic
- 🇬🇧United Kingdom jonathan1055
Thanks. Merged in d10-plus and cherry-picked into d10-theme and d9-basic. Both cherry-picks were clean and did not require any resolving of conflicts. Keeping the .gitlab-ci.yml file aligned where applicable means we make it easier for ourselves going forward merging things like this. But I didn't add this to main or d10-profile as the .css file is not so relevent on those branches. I presume that's OK?
- 🇪🇸Spain fjgarlin
100% ok. We will try to keep them aligned (by cherry picking) when it makes sense. If it doesn't make sense, it's better to keep things clean than add extra clutter.
- Merge request !27#3513408 Use _COMPOSER_YARN_INSTALL 0 to test the non-default Yarn install. → (Merged) created by jonathan1055
- 🇬🇧United Kingdom jonathan1055
I've created MR27 so that we have permanent test coverage for the non-default
_COMPOSER_YARN_INSTALL: 0
. But it won't have any effect until 📌 Exclude node_modules folder from artifacts Active is merged, so maybe do that one first. -
jonathan1055 →
committed a9150aeb on d10-theme
Issue #3513408 by jonathan1055: Add test coverage for stylelint job
-
jonathan1055 →
committed a9150aeb on d10-theme
- 🇬🇧United Kingdom jonathan1055
Thanks. I re-ran the MR27 but of course this project does not use 'main' it has to use
- project: $_GITLAB_TEMPLATES_REPO ref: $_GITLAB_TEMPLATES_REF
to enable it to function as desired when used in downstream pipelines. So I ran a pipeline via the issue fork UI setting _gitlab_templates_ref and _curl_templates_ref to 'main' and then we get the newly committed changes, and it works as required
https://git.drupalcode.org/issue/gitlab_templates_downstream-3513408/-/p...Merged and fixed.
Automatically closed - issue fixed for 2 weeks with no activity.